-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use constructor-style for NoopSubmitter #810
Use constructor-style for NoopSubmitter #810
Conversation
Hi @sebrandon1. Thanks for your PR. I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I don't think the linter will allow us to switch to this style of coding since for current use cases we are never setting a |
a28821c
to
efeb8c3
Compare
efeb8c3
to
b180830
Compare
error in check dallas: unable to rebase PR 810 from redhat-openshift-ecosystem/openshift-preflight branch main |
hi @sebrandon1, sorry for the failed job, we got an issue with the folder permissions in Dallas, but it is now fixed. Everything should work once your branch is rebased. |
b180830
to
4a07af1
Compare
Fully rebased on top of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, sebrandon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Inspired by #809
This change can be separated from the rest of the
lib
work, but using a constructor-style to creating thenoopSubmitter
objects.